-
Notifications
You must be signed in to change notification settings - Fork 30
Add helm_template_test.values #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helm_template_test.values #228
Conversation
abrisco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
I kinda suspect all the windows CI issues are a result of the paths not being normalized which might (based on where things fail) to be a preexisting issue. Unfortunately, I don't have a windows machine I can test on so this could be a pain for me to track down. |
8c0eeb1 to
e8fd858
Compare
|
I think the proper solution to the windows breakage is to wrap the values paths as @abrisco Do you have direct access to a Windows environment? Any way I can talk you into taking a look at this? |
I do not have a windows environment. All windows development has been done with github actions and prayer. Though I don't think the issue is too mysterious This seems like |
The missing path isn't a template file but rather |
e8fd858 to
65fa62e
Compare
65fa62e to
6da49dd
Compare
|
PTAL. I've duplicated the path munging in |
|
Thank you! |
Address part 2 of #226
valuesargument fromhelm_templateintohelm_template_test.helm_template_testto usesvaluesand also so that it detects that the extra values files are in fact used.